core(basic sender): fix trailing return type#2081
Merged
Merged
Conversation
Contributor
Author
Signed-off-by: romintomasetti <romin.tomasetti@gmail.com>
romintomasetti
force-pushed
the
env-trailing-return
branch
from
2f70a71 to
0cbb217
Compare
Contributor
Author
|
@ericniebler Not sure about the quality of the trailing return type but we need it in our code base to avoid incomplete type issues. Would you have a minute to take a look ? Thks! |
This was referenced May 19, 2026
ericniebler
reviewed
May 20, 2026
Co-authored-by: Eric Niebler <eniebler@boost.org>
Collaborator
|
/ok to test 161b336 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes a
decltype(auto)to a proper trailing return type, avoiding instantiation of stuff that ends up trying to instantiate stuff for incomplete types.I've added a new test that does not compile if the trailing return type is turned back to
decltype(auto).